[antlr-interest] Additional patches to C runtime WAS: Re: ANTLR 3.5 (was 3.4.1)

[Stephen Gaito]

Mike,

So, if you are suggesting that you have already fixed these other 
problems, I can see that both I and the wider community would love to 
have these patches. (In particular I am about to start moving nodes 
between trees...)

I have gotten Terence to add the new-and-improved Contribution (aka 
"GitHub pull") process to both the FAQ and the V3 README... so I will 
now place one or more "pull" requests for my changes.

See:

http://www.antlr.org/wiki/pages/viewpage.action?pageId=33947666

and in particular:

https://github.com/antlr/antlr3/blob/master/contributors.txt

However I am not sure I could shepherd your changes through this 
process... item (3) of the contributor's agreement means that I would 
have to take full responsibility for any IPR issues created by your 
patches.... which, sight-un-seen, could be nasty....

SO

It would be much better if you forked antlr/antlr3 on GitHub, added your 
changes, and then issued a pull request.  GitHub is really very easy to 
use (if you already know git).

If this is a great problem, let me know.

Regards,

Stephen Gaito

On 20/09/12 16:46, Mike Lischke wrote:
> Hey Stephen,
>
>> Which issues are these?
> You fixed the parent return problem in the common tree already, but there's still the issue with not-set parents when moving nodes between trees (antlr3basetree.c) and then I also removed the declaration of "true" and "false" from antlr3convertutf.h and replaced their occurrences in antlr3convertutf.c (as they caused warnings about duplicate declarations). Additionally, I renamed the member PROTOCOL_VERSION in antlr3debugeventlistener.h to lower case, as it conflicted with a macro of the same name (member names should never be written all upper case anyway). Finally I added a number of casts to get rid of compiler warnings.
>
>> I have "fixed" the couple of (release-phase) issues that have been
>> affecting my usage of the C target.
> So what is now the most up to date C runtime? The one from you on Github? I can make a diff and send it to you if you want.
>
> Btw: the runtime on antlr.org still has 3.0.1 as version number in the README, even for the 3.4 download. The same holds true for your Git repo.
>
> Mike